Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem.VirtualMemoryStat JSON fields capitalization and TestX_String tests #545

Closed
Lomanic opened this issue Jul 2, 2018 · 0 comments
Closed

Comments

@Lomanic
Copy link
Collaborator

Lomanic commented Jul 2, 2018

There are quite a few JSON fields all in lower case at mem/mem.go and following lines, whereas they only have their first capital letter in lower case in other packages and keep their initial capitalization. Shall we fix that in this package?

In the mean time, we should fix the TestX_String tests like this one to use reflection to dynamically get the fields instead of hard coding them inside the tests and to check their proper capitalization/name.

@shirou shirou added the v3 label Jul 3, 2018
@shirou shirou mentioned this issue Jul 6, 2018
9 tasks
@Lomanic Lomanic added the tests label Aug 29, 2020
@shirou shirou mentioned this issue Sep 7, 2020
14 tasks
shirou added a commit that referenced this issue Oct 18, 2020
shirou added a commit that referenced this issue Oct 25, 2020
shirou added a commit that referenced this issue Oct 26, 2020
@shirou shirou closed this as completed in bdd85e5 Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants