Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Command() handling and signal handling for launched processes. #354

Merged
merged 1 commit into from
May 1, 2017
Merged

Improve Command() handling and signal handling for launched processes. #354

merged 1 commit into from
May 1, 2017

Conversation

sean-
Copy link
Contributor

@sean- sean- commented Apr 27, 2017

Use Go's context package for command timeouts.

@sean- sean- mentioned this pull request Apr 27, 2017
@shirou
Copy link
Owner

shirou commented Apr 27, 2017

Thank you! It is exactly what I want to do. But context is a golang 1.8 feature so break some compatibility, could you wait merge until next patch release? gopsutil has monthly release policy, this means April 30.

@sean-
Copy link
Contributor Author

sean- commented Apr 28, 2017

... yes, I can wait until Monday to have this merged. :) LMK if you have any other concerns. Because this compatibility would be broken along API boundaries due to the removed symbols (I couldn't find any references to these exported, but unused symbols), it didn't seem problematic to merge. The dependency on context is a new dependency, but seems improbable that someone would suddenly need to compile current gopsutils without go1.8 available to them (static compilation of binaries ftw).

@shirou
Copy link
Owner

shirou commented Apr 28, 2017

Thank you. WaitTimeout and CombinedOutputTimeout are inside internal, so other applications can not use these. And I will write README to note new golang 1.8 dependency after merge.

@shirou shirou merged commit 772ab1f into shirou:master May 1, 2017
@sean- sean- deleted the fix-cmd-leak branch May 1, 2017 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants