2.13.0 automatically installs playwright when used as a dependency

[cyantree]

Describe the bug

In 2.13.0 the following postinstall script had been added to package.json:

"postinstall": "npx playwright install"

Therefore when installing Shoelace as a dependency also playwright gets installed. IMHO this is unnecessary as playwright is probably only used for developing the package.

Additional information

Is this behaviour intended? Is it maybe possible to do this only when installing it for development/contribution?

[ckawalar]

Hello everybody!

The change in 2.13.0 is also breaking when something like the
frontend-maven-plugin is used, that is using npm-cli.js for the installation:

[INFO] npm ERR! path /home/runner/work/projekt/node_modules/@shoelace-style/shoelace
[INFO] npm ERR! command failed
[INFO] npm ERR! command sh -c npx playwright install

[claviska]

This was added this as part of the Vue types PR in 4071904.

Hey @break-stuff, do you remember why this was added?

[break-stuff]

Ah, that was added because the packages were required to successfully run tests. Moving this to prepare instead of postinstall should fix this issue.

[claviska]

Thanks for clarifying. I'll get this updated :)

[break-stuff]

I just created a PR to fix this.

[claviska]

Merged. Thank you, sir!