Video Aspect Ratio is not correct

[ktprograms]

Describe the bug
When streaming using HaishinStudio, the stream has a resolution of 640x360, but the resolution in Camera2Source is 640x480. I looked at the code, and it seems like the resolution variable is never set in Camera2Source, so the stream resolution isn't set either. Even if I manually set the stream resolution to be equal to the source resolution, the video still has the wrong aspect ratio.

I'm testing this with commit 513e551, since the next commit seems to have broken video streaming (only the audio is available in VLC).

To Reproduce
Steps to reproduce the behavior:

1. Run HaishinStudio
2. Open the stream in VLC
3. See wrong aspect ratio

Expected behavior
The video has the correct aspect ratio.

I don't actually understand how/where the "correct" aspect ratio comes from, the variable setting seems a bit circular to me.

Screenshots

(The object in frame is a cube)

On Phone	In VLC

Desktop (please complete the following information):

• OS: macOS 11.6
• VLC media player 3.0.12.1 Vetinari (revision 3.0.12.1-0-g170157402b)

Smartphone (please complete the following information):

• Device: Samsung Galaxy A02
• OS: Android 11

[shogo4405]

Thank you fedback. I fixed it.

ViewSize

Before	After

[ktprograms]

Thanks! It's working great!

[ktprograms]

Sorry, it's still broken.

When I put cameraSource.resolution = Size(480, 640) in the onResume() method of the example app's CameraTabFragment, both the view on the phone and the stream are stretched.