Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video aspect ratio still incorrect with some resolution settings #56

Closed
ktprograms opened this issue Apr 13, 2022 · 1 comment
Closed

Comments

@ktprograms
Copy link

Describe the bug
Followup from #48, It works fine when not setting any resolution (so letting it use the default of 640x360), but when I add cameraSource.resolution = Size(480, 640) in the onResume() method of the example app's CameraTabFragment, both the view on the phone and the stream are stretched.

To Reproduce
Steps to reproduce the behavior:

  1. Add cameraSource.resolution = Size(480, 640) in the onResume() method of the example app's CameraTabFragment
  2. Hold phone in portrait mode
  3. Tap publish
  4. Open Stream
  5. Both the video on the phone and the stream are stretched.

Expected behavior
Video should not be stretched

Screenshots

Phone VLC

Desktop (please complete the following information):

  • OS: macOS 11.6
  • VLC media player 3.0.12.1 Vetinari (revision 3.0.12.1-0-g170157402b)

Smartphone (please complete the following information):

  • Device: Samsung Galaxy A02
  • OS: Android 11
@shogo4405
Copy link
Owner

Thank you feedback. i'm currently working to fix.
https://github.com/shogo4405/HaishinKit.kt/tree/feature/adjust-resolution

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants