Skip to content

Fixed the usage of SerialPort #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the usage of SerialPort #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/arduino-firmata.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

events = require 'eventemitter2'
{SerialPort} = serialport = require 'serialport'
serialport = require 'serialport'

debug = require('debug')('arduino-firmata')

Expand Down Expand Up @@ -42,6 +42,7 @@ exports = module.exports = class ArduinoFirmata extends events.EventEmitter2
callback null, devices

constructor: ->
super()
@status = ArduinoFirmata.Status.CLOSE
@wait_for_data = 0
@execute_multi_byte_command = 0
Expand All @@ -57,7 +58,7 @@ exports = module.exports = class ArduinoFirmata extends events.EventEmitter2
isOldArduinoDevice: ->
return /usbserial|USB/.test @serialport_name

connect: (@serialport_name, opts={baudrate: 57600}) ->
connect: (@serialport_name, opts={baudRate: 57600}) ->
opts.parser = serialport.parsers.raw
unless @serialport_name
ArduinoFirmata.list (err, devices) =>
Expand All @@ -82,7 +83,7 @@ exports = module.exports = class ArduinoFirmata extends events.EventEmitter2
@emit 'connect'
, io_init_wait

@serialport = new SerialPort @serialport_name, opts
@serialport = new serialport @serialport_name, opts
@serialport.once 'open', =>
cid = setInterval =>
debug 'request REPORT_VERSION'
Expand Down
5 changes: 2 additions & 3 deletions tests/test_arduino.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,9 @@ describe 'class ArduinoFirmata', ->

describe 'method list', ->

it 'should return list of serialports', (done) ->
it 'should return list of serialports', ->
ArduinoFirmata.list (err, devices) ->
assert.equal devices instanceof Array, true
done()
assert.equal (devices instanceof Array), true


describe 'instance of ArduinoFirmata', ->
Expand Down