Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised accessibility (a11y) in the cart view. #829

Merged
merged 18 commits into from
Sep 23, 2019
Merged

Conversation

devbucket
Copy link
Contributor

Description

To make the cart view more accessible, we added some optimisations to better comply with a11y specifications.

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@devbucket devbucket added the enhancement New feature or request label Sep 17, 2019
@devbucket devbucket self-assigned this Sep 17, 2019
@fkloes fkloes changed the base branch from v6.8.0 to v6.9.0 September 17, 2019 09:28
Copy link
Collaborator

@fkloes fkloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues i found where i wasn't able to comment code

  • users can't navigate to the cart on Android (cart icon hidden from the screen reader in both themes)

  • products can't be opened from the cart anymore

  • users can't remove products from the cart

  • the button which removes coupons from the cart doesn't have a label

  • at cart messages it might make sense that the screen reader also reads the state / classification of the message

@devbucket
Copy link
Contributor Author

Some issues i found where i wasn't able to comment code

  • users can't navigate to the cart on Android (cart icon hidden from the screen reader in both themes) => DONE
  • products can't be opened from the cart anymore => DONE
  • users can't remove products from the cart => DONE
  • the button which removes coupons from the cart doesn't have a label => DONE
  • at cart messages it might make sense that the screen reader also reads the state / classification of the message => DONE

Copy link
Collaborator

@fkloes fkloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the code comments two acceptance criteria are not fulfilled yet

  • Cart button is added back to main navigation voice output and made accessible on PDP
  • Make sure, images are not being read, to avoid duplicate content (see PLP)

Copy link
Contributor Author

@devbucket devbucket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Images are not read anymore
  • The cart button in the main navigation in iOS is part of the TabBar. I skipped this on purpose, since this would cause me changing the whole TabBar implementation. This will be done in another ticket.

@fkloes fkloes merged commit aa71b0d into v6.9.0 Sep 23, 2019
@fkloes fkloes deleted the PWA-2152-a11y-cart branch September 23, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants