-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimised accessibility (a11y) in the cart view. #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues i found where i wasn't able to comment code
-
users can't navigate to the cart on Android (cart icon hidden from the screen reader in both themes)
-
products can't be opened from the cart anymore
-
users can't remove products from the cart
-
the button which removes coupons from the cart doesn't have a label
-
at cart messages it might make sense that the screen reader also reads the state / classification of the message
themes/theme-gmd/pages/Cart/components/Item/components/Product/components/Layout/index.jsx
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the code comments two acceptance criteria are not fulfilled yet
- Cart button is added back to main navigation voice output and made accessible on PDP
- Make sure, images are not being read, to avoid duplicate content (see PLP)
...art/components/Item/components/Product/components/Layout/components/QuantityPicker/index.jsx
Show resolved
Hide resolved
…y to have all messages read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Images are not read anymore
- The cart button in the main navigation in iOS is part of the TabBar. I skipped this on purpose, since this would cause me changing the whole TabBar implementation. This will be done in another ticket.
Description
To make the cart view more accessible, we added some optimisations to better comply with a11y specifications.
Type of change
Please add an "x" into the option that is relevant: