Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation #105

Closed
2 of 3 tasks
KnVerey opened this issue Jun 2, 2017 · 5 comments
Closed
2 of 3 tasks

Better documentation #105

KnVerey opened this issue Jun 2, 2017 · 5 comments
Labels
krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 ✨ enhancement Improvement or small feature

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Jun 2, 2017

  • Improve readme (better explanation of core functionality and options, screenshots)
  • Convert all existing comment-based docs to rdoc or yard
  • Add comment-based docs for the key methods you need to use the tasks from Ruby instead of from the CLI (i.e. the run and run! methods of each Task class).
@KnVerey KnVerey mentioned this issue Jul 7, 2017
@kirs
Copy link
Contributor

kirs commented Jul 7, 2017

We use yard in Shopify core. Maybe it would make sense to use it here too.

@KnVerey
Copy link
Contributor Author

KnVerey commented Jul 7, 2017

Ideas for more readme enhancements:

  • Description of a few workflows like:
    • Getting started - using stuff from an 'examples' directory
    • Walk through the steps of a deploy
  • GIF screen recording of terminal running a deploy locally - put this right near the top of the readme

@KnVerey KnVerey added the ✨ enhancement Improvement or small feature label Jul 17, 2017
@KnVerey KnVerey added the 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 label Jan 9, 2019
@KnVerey
Copy link
Contributor Author

KnVerey commented Jan 9, 2019

  • Readme should reference a directory of examples, even if it is just our test fixtures

@KnVerey KnVerey mentioned this issue Jan 9, 2019
@dturn dturn assigned dturn and unassigned dturn Sep 24, 2019
@dirceu dirceu self-assigned this Oct 4, 2019
@dirceu dirceu removed their assignment Oct 8, 2019
@dirceu
Copy link
Contributor

dirceu commented Oct 9, 2019

After #581 and #582, do we need anything else?

I'm not sure about this:

Convert all existing comment-based docs to rdoc or yard

There aren't many comments, and most are specific to a particular condition inside a method, etc.

@KnVerey
Copy link
Contributor Author

KnVerey commented Oct 9, 2019

I'm inclined to agree now that only thing we need to document with yard are the public interfaces.

@dirceu dirceu closed this as completed Oct 10, 2019
@ghost ghost added the krane [ProdX-GSD] label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 ✨ enhancement Improvement or small feature
Projects
None yet
Development

No branches or pull requests

4 participants