Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control settings "None" on image sliders don't work #3711

Closed
phit opened this issue May 14, 2024 · 4 comments
Closed

Control settings "None" on image sliders don't work #3711

phit opened this issue May 14, 2024 · 4 comments

Comments

@phit
Copy link

phit commented May 14, 2024

PHP Version

N/A

Shopware Version

trunk 75ae67f

Expected behaviour

setting navigation arrows or dots for image slider or image gallery to none disables the controls

Actual behaviour

the arrows/dots stay and are no longer positioned correctly

How to reproduce

{% set navigationArrows = sliderConfig.navigationArrows.value %}

controls: sliderConfig.navigationArrows.value ? true : false,

All the output templates expect that selecting "None" sets the value to a falsey value or more specfically null.

But the settings in the administration appear to be broken, these should all be using :modelValue

<option :value="null">
{{ $tc('sw-cms.elements.imageSlider.config.label.navigationPositionNone') }}
</option>

<option :value="null">
{{ $tc('sw-cms.elements.imageSlider.config.label.navigationPositionNone') }}
</option>

@phit phit added the Bug label May 14, 2024
@mitelg
Copy link
Member

mitelg commented May 14, 2024

seems to be a similar issue: #3641

@shopwareBot
Copy link

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37811.

[created from NEXT-37811, comment 488246]

NinjaArmy added a commit to NinjaArmy/platform that referenced this issue Oct 4, 2024
@shopwareBot
Copy link

[public] Closed as duplicate of #4499

[created from NEXT-37811, comment 505760]

@mitelg mitelg closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants