-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control settings "None" on image sliders don't work #3711
Labels
Comments
seems to be a similar issue: #3641 |
This was referenced Aug 14, 2024
[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37811. [created from NEXT-37811, comment 488246] |
NinjaArmy
added a commit
to NinjaArmy/platform
that referenced
this issue
Oct 4, 2024
Resolves shopware#3711
[public] Closed as duplicate of #4499 [created from NEXT-37811, comment 505760] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PHP Version
N/A
Shopware Version
trunk 75ae67f
Expected behaviour
setting navigation arrows or dots for image slider or image gallery to none disables the controls
Actual behaviour
the arrows/dots stay and are no longer positioned correctly
How to reproduce
shopware/src/Storefront/Resources/views/storefront/element/cms-element-image-gallery.html.twig
Line 18 in 75ae67f
shopware/src/Storefront/Resources/views/storefront/element/cms-element-image-slider.html.twig
Line 13 in 75ae67f
All the output templates expect that selecting "None" sets the value to a falsey value or more specfically
null
.But the settings in the administration appear to be broken, these should all be using
:modelValue
shopware/src/Administration/Resources/app/administration/src/module/sw-cms/elements/image-slider/config/sw-cms-el-config-image-slider.html.twig
Lines 152 to 154 in 75ae67f
shopware/src/Administration/Resources/app/administration/src/module/sw-cms/elements/image-gallery/config/sw-cms-el-config-image-gallery.html.twig
Lines 206 to 208 in 75ae67f
The text was updated successfully, but these errors were encountered: