-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add updater_tools with package_patch command #163
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 95.98% 96.13% +0.15%
==========================================
Files 21 26 +5
Lines 2963 3078 +115
==========================================
+ Hits 2844 2959 +115
Misses 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
required Directory outputDirectory, | ||
}) async { | ||
final directory = switch (archiveType) { | ||
ArchiveType.aab => await _packageAndroidAabPatch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. One thing to consider is the format of the contents of each .zip as well as the contents of the output directory may change over time and it might be nice to have some sort of manifest which makes this explicit otherwise each time we change the output format or add new files, we'll need to support checking updater_tools versions etc. to decide how to interpret the output contents.
The contents of each zip is intended to be opaque, the idea being that Re: the content/layout of the output directory, I think that should be stable so long as we stick to a one-patch-artifact-per-arch model. We can always ask |
Description
Adds an initial
updater_tools package_patch
command that accepts two aabs (a release and a patch) and generates patch artifacts for them.Sample usage:
Outputs to
$HOME/Desktop/testout
:Where the contents of each .zip file is the
dlc.vmcode
produced by thepatch
executable.Type of Change