Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding CI for updater tools #166

Closed
wants to merge 1 commit into from

Conversation

erickzanardo
Copy link

Description

While getting up to speed on the updater_tools, I noticed it didn't had a workflow for itself. This PR adds one.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@erickzanardo erickzanardo requested a review from bryanoltman May 20, 2024 17:23
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (6ab6972) to head (8092940).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          28       28           
  Lines        3091     3091           
=======================================
  Hits         2972     2972           
  Misses        119      119           
Flag Coverage Δ
updater_tools 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bryanoltman bryanoltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erickzanardo
Copy link
Author

Nvm, I just realized that we have a matrix that runs for all dart packages! TIL

@erickzanardo
Copy link
Author

This already exists in main.yaml. See https://github.com/shorebirdtech/updater/blob/main/.github/workflows/main.yaml#L31-L3

Yeah, I realized that when following up the CI execution 😅, my bad

@erickzanardo erickzanardo deleted the feat/adding-updater-tools-ci branch May 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants