feat: store patch hash on disk #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanoltman
commented
May 21, 2024
| @@ -17,13 +17,17 @@ const PATCHES_DIR_NAME: &str = "patches"; | |||
| const PATCHES_STATE_FILE_NAME: &str = "patches_state.json"; | |||
| const PATCH_ARTIFACT_FILENAME: &str = "dlc.vmcode"; | |||
|
|
|||
| #[derive(Copy, Clone, Debug, Deserialize, Serialize, PartialEq, Eq, Hash)] | |||
There was a problem hiding this comment.
String does not implement Copy, so we lose the ability to make this struct Copyable. This is why this PR introduces the as_refs and clones below.
There was a problem hiding this comment.
This will I guess all go away when we store the hash inside the artifact (bundle) in some way I guess.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 96.19% 96.21% +0.02%
==========================================
Files 28 28
Lines 3126 3148 +22
==========================================
+ Hits 3007 3029 +22
Misses 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erickzanardo
approved these changes
May 21, 2024
eseidel
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write patch hash to disk alongside number and size.
Type of Change