feat: Support iOS #23
Conversation
| if self.is_known_bad_patch(&PatchInfo { | ||
| path: String::new(), | ||
| number: slot.patch_number, | ||
| }) { |
There was a problem hiding this comment.
I'd add a fixme here to update is_known_bad_patch to only require a patch number
| inflate(&download_path, base_r, &output_path) | ||
| } | ||
|
|
||
| #[cfg(not(any(target_os = "android", test)))] |
There was a problem hiding this comment.
Thoughts on making this explicit that we're targeting iOS (as opposed to "not Android"). Not sure how doable that is since we're also making sure this isn't a test cfg
There was a problem hiding this comment.
In this case iOS should use this function, just doesn't yet. That's why iOS patch files are MB instead of bytes.
| @@ -154,7 +154,10 @@ impl UpdaterState { | |||
| return None; | |||
| } | |||
| let slot = &self.slots[index]; | |||
| Some(slot.to_patch_info()) | |||
| Some(PatchInfo { | |||
| path: self.patch_path(index).to_str().unwrap().to_owned(), | |||
There was a problem hiding this comment.
Is it safe to unwrap here?
There was a problem hiding this comment.
Good question. Probably isn't. Looking.
| fn validate_slot(&self, slot: &Slot) -> bool { | ||
| // Check if the patch is known bad. | ||
| if self.is_known_bad_patch(&slot.to_patch_info()) { | ||
| if self.is_known_bad_patch(&PatchInfo { |
There was a problem hiding this comment.
Can we change the signature to only accept a patch number here so we don’t need to pass an empty path?
| .slots | ||
| .iter() | ||
| .position(|s| s.patch_number == slot.patch_number); | ||
| let patch_path = self.patch_path(index.unwrap()); |
There was a problem hiding this comment.
Same here about unwrapping and whether it’s safe?
Adds support for iOS to the updater library.
Refactored the android-specific code into an
androidmodule.The tests still mostly use the
androidcode, rather than testing iOS paths too, but that can be fixed in a follow-up.I had to change how "latest patch number" works to understand when patch files disappear from disk (which I thought was happening on iOS initially).
I also had to make status.json not store absolute paths to patch files (since the absolute path changes per-xcode run on iOS).