Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log more friendly error message in case of no internet connection #67

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

Inspects the error message produced by our patch check request to see if it matches what we expect in cases of no internet connection. If so, log "Patch check request failed due to network error. Please check your internet connection".

Fixes shorebirdtech/shorebird#759

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested a review from eseidel August 7, 2023 21:42
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (99f3005) 97.33% compared to head (2438cb4) 97.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   97.33%   97.43%   +0.09%     
==========================================
  Files           9        9              
  Lines        1725     1829     +104     
==========================================
+ Hits         1679     1782     +103     
- Misses         46       47       +1     
Files Changed Coverage Δ
library/src/network.rs 99.02% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit 7417429 into main Aug 17, 2023
@bryanoltman bryanoltman deleted the bo/no-internet-error branch August 17, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: better logs in case of no internet connection
2 participants