feat: add support for reporting patch install events #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 97.24% 97.33% +0.08%
==========================================
Files 9 9
Lines 1598 1725 +127
==========================================
+ Hits 1554 1679 +125
- Misses 44 46 +2
☔ View full report in Codecov by Sentry. |
felangel
reviewed
Aug 11, 2023
felangel
reviewed
Aug 11, 2023
Co-authored-by: Felix Angelov <felix@shorebird.dev>
felangel
reviewed
Aug 11, 2023
Comment on lines
+281
to
+283
| let patch_install_success_fn = config.network_hooks.patch_install_success_fn; | ||
| let url = &patches_events_url(&config.base_url); | ||
| patch_install_success_fn(url, request) |
There was a problem hiding this comment.
Suggested change
| let patch_install_success_fn = config.network_hooks.patch_install_success_fn; | |
| let url = &patches_events_url(&config.base_url); | |
| patch_install_success_fn(url, request) | |
| let url = &patches_events_url(&config.base_url); | |
| config.network_hooks.patch_install_success_fn(url, request) |
nit but would this work?
There was a problem hiding this comment.
It would need to be (config.network_hooks.patch_install_success_fn)(url, request), but yeah, that would work. I did it this way for consistency with the other functions in that file that use network hooks.
felangel
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the PatchInstallEvent type and posts to the
api/v1/patches/eventsendpoint when the engine reports a successful launch and we mark a patch as good.Type of Change