Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put call to report launch success on bg thread. #72

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

bryanoltman
Copy link
Contributor

Description

We were previously making a blocking network request on the main thread. This moves that call to a background thread.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@bryanoltman bryanoltman requested a review from eseidel August 17, 2023 18:32
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (7417429) 97.43% compared to head (0595ca1) 97.48%.

❗ Current head 0595ca1 differs from pull request most recent head d02263c. Consider uploading reports for the commit d02263c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   97.43%   97.48%   +0.05%     
==========================================
  Files           9        9              
  Lines        1829     1830       +1     
==========================================
+ Hits         1782     1784       +2     
+ Misses         47       46       -1     
Files Changed Coverage Δ
library/src/cache.rs 93.47% <100.00%> (+0.04%) ⬆️
library/src/network.rs 99.00% <100.00%> (-0.02%) ⬇️
library/src/updater.rs 97.70% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanoltman bryanoltman merged commit 53072a9 into main Aug 17, 2023
@bryanoltman bryanoltman deleted the bo/bg-request branch August 17, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants