fix: show patch check info in logs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 97.48% 97.49%
=======================================
Files 9 9
Lines 1830 1834 +4
=======================================
+ Hits 1784 1788 +4
Misses 46 46
☔ View full report in Codecov by Sentry. |
felangel
approved these changes
Aug 31, 2023
bryanoltman
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We directed users to look for this log, but it was no longer visible after my recent changes to reduce logging, so adding back.
https://docs.shorebird.dev/troubleshooting#how-to-fix-it-1
I don't know how to test in rust for log calls, so just leaving
a comment for now.