refactor: move shorebird_code_push_io and _web into src/ #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users were sometimes importing the _web version thinking it was the "web safe" import, rather than shorebird_code_push.dart and then being surprised when ShorebirdCodePush did nothing. Fixes shorebirdtech/shorebird#1209
eseidel
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
===========================================
+ Coverage 97.49% 100.00% +2.50%
===========================================
Files 9 4 -5
Lines 1834 57 -1777
===========================================
- Hits 1788 57 -1731
+ Misses 46 0 -46
☔ View full report in Codecov by Sentry. |
|
Clearly I need to wire up coverage flags for this repo too. |
bryanoltman
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users were sometimes importing the _web version thinking it
was the "web safe" import, rather than shorebird_code_push.dart
and then being surprised when ShorebirdCodePush did nothing.
Fixes shorebirdtech/shorebird#1209