fix: don't regenerate client id if UpdaterState successfully loaded

[bryanoltman]

Description

Fixes issue where client_id was being regenerated when the app's release version changed or when the previous state failed to validate.

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[codecov]

Codecov Report

Patch coverage: 97.95% and project coverage change: -2.47% ⚠️

Comparison is base (e14f630) 100.00% compared to head (932ec2f) 97.53%.

Additional details and impacted files

@@             Coverage Diff             @@
##              main      #76      +/-   ##
===========================================
- Coverage   100.00%   97.53%   -2.47%     
===========================================
  Files            4        9       +5     
  Lines           57     1864    +1807     
===========================================
+ Hits            57     1818    +1761     
- Misses           0       46      +46     

Files Changed	Coverage Δ
library/src/cache.rs	93.91% <97.95%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eseidel]

Patch is fine, I'm not sure it's worth the hassle (since we don't currently use the client_id do we?) and it's just more functionality to maintain. But this does make the client_id more stable (as someone might expect) and does add more testing so 🤷