Idle durations configurable #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortbloke
added a commit
that referenced
this pull request
Sep 7, 2019
* Add support for varrying the number of CPU cores being stressed. Defauly will be ALL, prevously was fixed at 4 * Remove f string formatting, to maintain Python 3.0 support * Idle durations configurable (#3) * Add ability to adjust idle time. Make stress duration more specific (#2) * Don't wrap simple call for cpu core count * remove : * add gh-actions config * gh-actions fix * Trigger tests * Apply black fixes * Fix merge issues * Address PR feedback: * Use vcgencmd as default for for temperature and frequency measurement. Able to be overriden by passing file source as argument. * Remove default file locations for frequency and temp. User would need to know and specify this now. * If vcgencmd is not found, will now throw an exception not fall back to default file method. * Always measure frequency. * Format printing of temperature and frequency measurements. * Simplication of setting a solid background colour for plot. * Fix test failures: * Change measure_core_frequency to return a float. Print messages used to format to zero decimal places. * Update test to provide frequency file. As frequency is recorded by default. * black fix * Increase code coverage by covering plot of frequency. * make cooldown poll interval configurable (to speed up unit test) * Add additional tests. Improve code coverage. * rename transparent plot argument to make it more logical * Remove test which would call vcgencmd as this needs to be mocked. Package isn't available to be installed on circleci test system. * black fixes * provide example file locations in help text for temperature and frequency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.