For #35229: Added support for 'additional_server_presets' in read req… #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotgun_api3/shotgun.py
Outdated
| """Wrapper for ensure_support""" | ||
| return self._ensure_support({ | ||
| 'version': (6, 3, 11), | ||
| 'label': 'project parameter' |
There was a problem hiding this comment.
Label needs to be updated.
There was a problem hiding this comment.
yes! Plan is to update before merging...
There was a problem hiding this comment.
The string with the label says project parameter. It should be something for the presets. Just making sure that's the bit you were planning on updating before a merge.
|
CR done! Minor comments only from me! |
added 2 commits
February 29, 2016 09:19
shotgun_api3/shotgun.py
Outdated
| 'label': 'project parameter' | ||
| }, True) | ||
|
|
||
| def ensure_support_for_additional_server_presets(self): |
There was a problem hiding this comment.
Should be "additional_filter_presets".
| def find(self, entity_type, filters, fields=None, order=None, | ||
| filter_operator=None, limit=0, retired_only=False, page=0, | ||
| include_archived_projects=True): | ||
| include_archived_projects=True, additional_filter_presets=None): |
There was a problem hiding this comment.
Should this be added to find_one as well?
…com/shotgunsoftware/python-api into 35229_add_additional_server_presets # By Neil Grey (4) and others # Via Rob Blau (2) and others * '35229_add_additional_server_presets' of https://github.com/shotgunsoftware/python-api: shotgun.py: optional extra_auth_params added to Config object For #35620 - Enable Slack notifications Bump version to v3.0.30.dev Reverts image upload default field name change. Bumping master to 3.0.29.dev Prepping for release of 3.0.28 For #35260 : Adding classmethods to SgTimezone for nested class backwards compatability, as well as docstrings to better explain the module For #35260: Refactoring scoping of sgtimezone so that dates are picklable and convertable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uests