#35786 Adds basic find() ordering support to mockgun. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotgun_api3/lib/mockgun.py
Outdated
| # order: [{"field_name": "code", "direction": "asc"}, ... ] | ||
| for order_entry in order: | ||
| if "field_name" not in order_entry: | ||
| raise ValueError("Order clauses must be list of dicts with keys field_name and direction!") |
There was a problem hiding this comment.
minor: maybe single quotes around the key names to distinguish?
'field_name' and 'direction'
|
One very minor comment. This one looks good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, mockgun just ignored the ordering parameter on
find()andfind_one(). This adds basic ordering support. This change is needed for the unit test added here: shotgunsoftware/tk-core#266