For #46904, site wide tk-config-default2 #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-t
approved these changes
Mar 23, 2018
shotgun_api3/lib/mockgun/mockgun.py
Outdated
|
|
||
| def find( | ||
| self, | ||
| entity_type, filters, fields=None, |
There was a problem hiding this comment.
this formatting seems a bit arbitrary. Any reason it's done this way?
There was a problem hiding this comment.
First line is self, next three is the most common-only used params to the method and then the rest. Should I simply break them on two lines? One arg per line seems wasteful to me.
shotgun_api3/lib/mockgun/mockgun.py
Outdated
| results = self.find(entity_type, filters, fields=fields, order=order, filter_operator=filter_operator, retired_only=retired_only) | ||
| def find_one( | ||
| self, | ||
| entity_type, filters, fields=None, |
| "%s.%s is of type entity, but data %s does not contain 'type' and 'id'" | ||
| % (entity_type, field, item) | ||
| ) | ||
| # elif item["type"] not in field_info["properties"]["valid_types"]["value"]: |
There was a problem hiding this comment.
any reason why this is commented out? maybe make a comment to say why it has been left in?
There was a problem hiding this comment.
Maybe it's not obvious from the diff, but it was already commented out. I only reformatted it because it was longer than 120 chars. Unfortunately we don't know why it was commented out...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing unit tests in Toolkit I stumbled upon this bug, where searching for a sub-entity field would crash if any of the sub-entity field was set to
None. See unit test for more info.Also, PEP8ed
mockgun.py. The actual fix is on line 679