Skip to content

Conversation

000paradox000
Copy link
Contributor

This PR add support for python 3.9 to the python-api. As an extra this PR removes some warnings when testing.

The changes are:

  • Call the proper method for encoding according to python version: encodestring and encodebytes
  • Call the proper method for spliturl according to python verson
  • Fix configparser when running with scaped characters in python 2.7
  • Replace self.assertEquals with self.assertEqual when unittesting

Copy link
Contributor

@mathurf mathurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job!

I also tested with some little Python API script with python 2.7 and 3.9 and everything looks good.

:shipit:

@000paradox000 000paradox000 merged commit 8877bef into master Jan 18, 2022
@000paradox000 000paradox000 deleted the SG-25029_add_python_3.9_coverage_to_python_api_azure_pipelines_tests branch January 18, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants