Skip to content

SG-32806 Upgrade httplib2 to 0.22.0 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

carlos-villavicencio-adsk
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk commented Sep 18, 2023

In preparation for Python 3.10 we need to upgrade this dependency to remove warnings on CI and potential deprecation.

julien-lang
julien-lang previously approved these changes Sep 18, 2023
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do you have any idea why we use httplib2 anyway?

@carlos-villavicencio-adsk carlos-villavicencio-adsk force-pushed the ticket/SG-32806_upgrade_httplib2 branch from 6f652c6 to 9245db8 Compare September 18, 2023 14:50
@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the title SG-32806 Upgrade httplib2 to 0.22.0. Also pyparsing==3.1.1 SG-32806 Upgrade httplib2 to 0.22.0 Sep 18, 2023
@carlos-villavicencio-adsk
Copy link
Contributor Author

Do you have any idea why we use httplib2 anyway?

@julien-lang probably because of Python 2 support: see this line.

Would you mind reviewing this again? I had to force-push to overwrite my last commit in favor of this one.

@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit 2175515 into master Sep 18, 2023
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-32806_upgrade_httplib2 branch September 18, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants