-
Notifications
You must be signed in to change notification settings - Fork 1
Fix1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shoyan
wants to merge
14
commits into
master
Choose a base branch
from
fix1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix1 #1
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7c4229b
fix
72152a1
gem install
11e5517
saddler
d2dca04
fix
ec54e7f
Fix
4fb4381
fix
03c5e58
fix
17e179f
fix
0368ecf
fix
31065f3
fix
fe06fc9
fix
b26be54
fix
4a01157
fix
da4bca3
fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,20 @@ | ||
#!/bin/bash | ||
|
||
echo "Start" | ||
LIST=`git diff --name-only origin/master | grep -e '.php$'` | ||
|
||
LIST=`git diff --name-only origin/master | grep '.php'` | ||
if [ -z $LIST ]; then | ||
echo "Success" | ||
if [ -z "$LIST" ]; then | ||
echo "PHP file not changed." | ||
exit 0 | ||
fi | ||
|
||
vendor/bin/phpcs index.php --standard=PSR2 --report=checkstyle \ | ||
| checkstyle_filter-git diff origin/master | ||
|
||
if [ -n "$CI_PULL_REQUESTS" ]; then | ||
git diff --name-only origin/master \ | ||
| grep -e '.php$' \ | ||
| xargs vendor/bin/phpcs -n --standard=PSR2 --report=checkstyle \ | ||
| bundle exec checkstyle_filter-git diff origin/master \ | ||
| bundle exec saddler report \ | ||
--require saddler/reporter/github \ | ||
--reporter Saddler::Reporter::Github::PullRequestReviewComment | ||
fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,20 @@ | ||
<?php | ||
echo 'Hello world'; | ||
if (true) { | ||
echo "True"; | ||
} | ||
|
||
function hoge() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ERROR: Opening brace should be on a new line |
||
return true; | ||
} | ||
|
||
function moge() | ||
{ | ||
return true; | ||
} | ||
|
||
if (true) { | ||
echo "True"; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ERROR: Expected 1 blank line at end of file; 3 found |
||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?php | ||
echo 'Hello world'; | ||
if (true) { | ||
echo "True"; | ||
} | ||
|
||
function hoge() | ||
{ | ||
return true; | ||
} | ||
|
||
function moge() | ||
{ | ||
return true; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERROR: Opening brace should be on a new line