Rename "ddc-vim-lsp" source to "vim-lsp" #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because almost of source names don't have "ddc-" prefix.
|
@thinca |
thinca
added a commit
to thinca/config
that referenced
this pull request
Sep 24, 2021
Shougo
added a commit
to Shougo/ddc-source-lsp
that referenced
this pull request
Sep 26, 2021
…sp". Because the source name should be equal to the repository name shun/ddc-source-vim-lsp#7
kakubin
added a commit
to kakubin/dotfiles
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because almost of source names don't have "ddc-" prefix.
Of course, this change has a compatibility break 😢
But ddc.vim has not yet been major version(v1) released.
This means users of ddc.vim may accept breaking changes for now.