[auth] feat: add an auth module to shuttle common #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
This is really cool! LGTM, I'll take another look later at the "hack" tests later and read more up on JWTs to get a deeper understanding, but I think we can merge this. It might be a good idea to get a review from Damien as well, if he has time.
This was very well commented, thanks! I left a suggestion for a tiny bit more. 🙂
Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com>
chesedo
deleted the
feature/eng-433-add-an-auth-module-to-shuttle_common
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect we'll want more helpers, but am not sure what they are yet