503 migrate tests to junit5 #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason to instantiate a JFXPanel instead of any other FX control? This implies a javafx-swing dependency that may not be present. |
|
The JFXPanel was the only way to bootstrap a JavaFX runtime besides instantiating a real JavaFX application. The issue with the javafx-swing dependency was not a problem at that time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#503
JfxRunner (#504) was replaced by JfxToolkitExtension, which initializes the JavaFX Toolkit before all tests are made, and a method on FxTestingUtils (runInFXThread), which runs a code block on Platform.runLater()
BooksExampleIT from books-example and IntegrationTestWithTestFX from fx-root-example have a dependency on junit4. They both use GuiTest from TestFX-legacy, which uses junit4 on the background.