Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregation with persistence store AGG_TIMESTAMP not applying for group by #1593

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

niveathika
Copy link
Member

Purpose

$subject fix #1591

Security checks

@codecov-io
Copy link

Codecov Report

Merging #1593 into master will increase coverage by 0.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1593      +/-   ##
============================================
+ Coverage      67.7%   67.72%   +0.01%     
  Complexity       45       45              
============================================
  Files           651      651              
  Lines         27489    27492       +3     
  Branches       4335     4336       +1     
============================================
+ Hits          18612    18619       +7     
+ Misses         7064     7059       -5     
- Partials       1813     1814       +1
Impacted Files Coverage Δ Complexity Δ
...io/siddhi/core/aggregation/AggregationRuntime.java 53.11% <62.5%> (+0.46%) 0 <0> (ø) ⬇️
...ore/util/persistence/InMemoryPersistenceStore.java 53.84% <0%> (-5.13%) 0% <0%> (ø)
...ut/stream/state/AbsentStreamPreStateProcessor.java 82.11% <0%> (-1.33%) 0% <0%> (ø)
.../io/siddhi/core/util/snapshot/SnapshotService.java 70.6% <0%> (-0.21%) 0% <0%> (ø)
...a/io/siddhi/core/query/selector/QuerySelector.java 82% <0%> (+0.69%) 0% <0%> (ø) ⬇️
...rocessor/stream/window/SessionWindowProcessor.java 66.41% <0%> (+1.49%) 0% <0%> (ø) ⬇️
...c/main/java/io/siddhi/core/util/ThreadBarrier.java 100% <0%> (+20%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db793ca...1129600. Read the comment docs.

@suhothayan suhothayan merged commit 43b2db4 into siddhi-io:master Dec 19, 2019
@niveathika niveathika changed the title Fix aggregation with persistence store AGG_TIMESTAMP not applying Fix aggregation with persistence store AGG_TIMESTAMP not applying for group by Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In aggregated tables, group by AGG_TIMESTAMP does not populate correct results
3 participants