-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use Nuxt3 offical starter instead of sidebase/merino #36
Conversation
@@ -10,36 +10,73 @@ jobs: | |||
testCodebase: | |||
runs-on: ubuntu-latest | |||
steps: | |||
- uses: actions/checkout@v3 | |||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend you to add CI
environment variable. It's an unspoken convention which some libraries use to optimize their build process for CI runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's tackle this in another PR sometime later 😊
}, | ||
|
||
// Silent the stylistic rules in you IDE, but still auto fix them | ||
"eslint.rules.customizations": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes there is! This is because our eslint config handles stylistics adjustments (such as indents). Changing this setting in the vscode settings, ensures that the style preferences set by eslint are used and not those that the editor has defined through extensions such as prettier.
This settings and the extention files are the default provided bu antfu when he explains how to setup his linter.
command: 'nuxt typecheck' | ||
}, { | ||
name: 'start', | ||
command: 'NODE_ENV=production node .output/server/index.mjs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this command in the typescript config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally speaking it does not 100% relate to this, however as the project uses typescript by default, I added this here, to avoid having to create another config, just for this command.
Co-authored-by: Marsel Shayhin <18054980+phoenix-ru@users.noreply.github.com>
This PR:
create-sidebase
up to date on Nuxt versionsantfu
ESLint config and oxlint as the provided default lintersnpm
topnpm
Checklist:
#
)