fix: several fixes for GPT and ZFS #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
fix/zfs-gpt
branch
2 times, most recently
from
d1e082c to
7e38dea
Compare
frezbo
approved these changes
Aug 20, 2024
|
@dsseng I fixed ZFS probing, you missed the fact that uberblocks start at offset 128K. |
Fix ZFS probing, and skip if the device is too small to avoid printing weird errors in probe logs. Fix GPT allocation/size discovery to match `sfdisk`: first usable LBA should be aligned to the partition boundary, and allocatable space should be also aligned as well. Fix ZFS tests to use testdata, so that we can run tests in local mode. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ZFS probing, and skip if the device is too small to avoid printing weird errors in probe logs.
Fix GPT allocation/size discovery to match
sfdisk: first usable LBA should be aligned to the partition boundary, and allocatable space should be also aligned as well.Fix ZFS tests to use testdata, so that we can run tests in local mode.