Added functionality to iterate through the values in Acccept header #103
Conversation
…er and search for those file types
|
|
||
| will serve the relative folder via port 5000 | ||
|
|
||
| If you want canned to iterate through all accepted content types in the `Accept` header, use |
There was a problem hiding this comment.
Maybe better
If you want canned to accept the first matching content type when sending multiple Accept headers you can pass
$canned --relaxed-accept ./my/responses
I would also prefer to have that be a --relaxed-accept without the true, as well as not having the word iterate as it seems very implementation specific.
There was a problem hiding this comment.
Yes, I agree that it shouldn't be implementation specific. I'm OK with --relaxed_accept but I think that it should be --relaxed_accept=true to remain consistent with how the flag for cors is used -- i.e. --cors=true. Of course, it's up to you since you're the owner of the library :)
|
Sorry took me a long time to review, it has been a crazy week. But I like the PR a lot some small comments and I'm gonna merge this happily. Thanks so much for your work! |
... and search for those file types