Add support for empty files, returns status code 204 by default #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks will look at it when I'm back at my laptop later, but first look looks great! Want to add yourself to the contributors in the readme? |
canned.js
Outdated
There was a problem hiding this comment.
Sorry to be that picky, but the coding style is without semicolon where possible and I want to keep it consistent.
|
Besides the really minor things 👍 |
|
Ah, thought I caught all the semicolons. Hard to break the habit - I usually keep them in for my own projects. Just pushed a new commit fixing that and adding me to the readme! |
sideshowcoder
added a commit
that referenced
this pull request
Jul 12, 2014
Add support for empty files, returns status code 204 by default
|
Thanks for your work. :) I will push to npm soon as well. FYI I just pushed it up to npm. |
sideshowcoder
added a commit
that referenced
this pull request
Nov 19, 2014
Add support for empty files, returns status code 204 by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #35.