Wildcard fallbacks feature #64
Conversation
|
That sounds like a good idea, I would like to stay with the naming conventions if possible which right now uses Other than that, that sounds like a great idea! If I can be of any help let me know, I'm happy to accept contributions and help where I can along the way. |
…ring will generate all the possible combinations
|
Hi, again, here is a PoC implementation of the feature. I've added a parameter so that if anyone doesn't like "any" or wants to use ":id" as a directory name for avoiding name collisions they can do it. This implementation is missing some tests and documentation, but I'd like first to hear if you like it or not before investing more time on it. I'd also appreciate some help with these remaining issues, if anyone else in the project is interested in this. |
| @@ -28,6 +31,7 @@ var dir = '' | |||
| , cors_headers = argv.headers | |||
| , logger | |||
| , cannedDir | |||
| , wildcard = argv.wildcard | |||
There was a problem hiding this comment.
It's going to be important to have a sane default here. just to keep in mind.
There was a problem hiding this comment.
Default is set to 'any' via optimist's default(). Is that enough?
There was a problem hiding this comment.
Oh yeah sorry misread 👍 all good!
|
I like the general idea a lot, thanks for taking the time, I think seeing it in code made it clearer what you want to get out of it. I think the general approach is good, for maintainance purpose I would prefer to see the functionality in utils to be extracted to some kind of Again thanks for taking the time and happy hacking 👍 |
…hen running tests)
|
Hi again. I've refactored the path generation code following your suggestion into its own module, which I named 'lookup' because that's what made more sense to me, feel free to remove it to anything else if you find a better name (naming is difficult!!!). I've also added a few more tests to canned.spec and a unit test for the path generation algorithm. Anything else I can help with so that we get this into canned? |
|
From first glance this looks good, I'll have a more thourogh look tomorrow and give some more feedback but I'm pretty sure this gets in before the end of the week for sure 👍 Thanks for all your work! |
|
Good to hear that. Thank you too for making canned open source. |
|
Merged with 897660f thanks so much for all your work! I will release it in the next version, and I hope you don't mind I ajusted the style a little to fit the rest of the project, I don't mind either style but like to have the consistency, sorry hope it does not bother you. |
|
I just realized some help with the docs would be awesome! Do you mind taking a look at the readme? I copied the PR description but more would be better. Thanks so much! |
Hi, I'd like to suggest a feature which maybe you can find interesting too.
It would be very useful to have 'wildcard' directories, so that if for given a request like:
you don't have a file in
./canned/api/users/1/profile/index.get.jsonthen it would look for a file in./canned/api/users/:id/index.get.jsonor similar.This could be extended to support nested wildcards like
./canned/api/customer/:id/invoice/:id/index.get.jsonand so forth.I'll try to find some time to start a PoC implementation if you like the idea.