fix: The removeIdleTimeoutConnectionsTimer did not clean up when the …

[foxling]

…pool was closed.

#1917

[wellwelwel]

Thanks, @foxling 🙋🏻‍♂️

Do you think there is a way to test it in an unit test? Maybe we can use the steps from #1917 (comment).

[sidorares]

happy to merge without a unit test ( but if we can add - great ). We need to detect leaking timer handles though, the test #1917 (comment) would pass OK but the process then won't exit for some time. As an option - spawn test in its own child process and expect it to finish within reasonable time

[foxling]

setTimeout(() => process.exit(0), 1000)
In this unit test, which probably encountered this problem at that time, removing this code would fit the test scenario?

[wellwelwel]

setTimeout(() => process.exit(0), 1000) In this unit test, which probably encountered this problem at that time, removing this code would fit the test scenario, so is that it?

@foxling, that makes sense to me.