Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): remove add target files option in fuzzjob view and fix controller #226

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

jones718
Copy link
Collaborator

Copy link
Collaborator

@p4cx p4cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the status messages (Success, Error)

db.session.add(newFjDeploymentPackage)
db.session.commit()

return "Success: Uploaded new target!", "success"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please remove one "Success".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the case several times.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I removed them.

@TomSie TomSie merged commit 79d66aa into master Jul 23, 2020
@TomSie TomSie deleted the fix_web_remove_option branch July 23, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants