-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(doc): update comment on opsec #270
Conversation
address #249 and bot PRs
@@ -355,5 +355,8 @@ Please note: We strongly discourage connecting FLUFFI to an untrusted network (s | |||
|
|||
## A Note on Operational Security | |||
|
|||
FLUFFI was not meant to be used in hostile environments, which is why FLUFFI's internal protocol is not hardened against attacks. It is therefore recommended to operate FLUFFI in an isolated environment, to which you can restrict access, and only allow the master to be connected to the internet via NAT. | |||
Furthermore, it is strongly recommended to change the Polemarch user credentials, which are initially set to be `admin:admin`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand not having admin:admin
written directly in the docs, but why remove this line entirely instead of just dropping the part after the comma? Are there any issues that crop up if the polemarch credentials are changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought process when removing this line was something like this:
- Is this really the only recommendation about security configuration we give here? These are certainly not the only default credentials that we have in the project, and obviously all the others need to be changed as well (think about these and the correspondig documentation here )
- So why do we need to address this one instance here explicitly?
- Then I'd better remove this line, because otherwise one might think this is the only thing to take care of when installing FLUFFI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't look at it this way, thanks for clarifying. Let's remove the line for now and think about creating a complete list of all the places where default credentials are used/should be changed. Ideally, we would want to have a guide for performing at least basic hardening of the FUN.
@@ -355,5 +355,8 @@ Please note: We strongly discourage connecting FLUFFI to an untrusted network (s | |||
|
|||
## A Note on Operational Security | |||
|
|||
FLUFFI was not meant to be used in hostile environments, which is why FLUFFI's internal protocol is not hardened against attacks. It is therefore recommended to operate FLUFFI in an isolated environment, to which you can restrict access, and only allow the master to be connected to the internet via NAT. | |||
Furthermore, it is strongly recommended to change the Polemarch user credentials, which are initially set to be `admin:admin`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't look at it this way, thanks for clarifying. Let's remove the line for now and think about creating a complete list of all the places where default credentials are used/should be changed. Ideally, we would want to have a guide for performing at least basic hardening of the FUN.
address #249 and bot PRs