fix(core/select): prevent string to be spread by '...' operator (#166)

siemens · Nov 23, 2022 · ec6744a · ec6744a
1 parent 108e892
commit ec6744a
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 11 deletions.
diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx
@@ -8,16 +8,16 @@
  */
 
 import {
-    Component,
-    Element,
-    Event,
-    EventEmitter,
-    h,
-    Host,
-    Listen,
-    Prop,
-    State,
-    Watch
+  Component,
+  Element,
+  Event,
+  EventEmitter,
+  h,
+  Host,
+  Listen,
+  Prop,
+  State,
+  Watch,
 } from '@stencil/core';
 
 @Component({
@@ -124,9 +124,17 @@ export class Select {
 
   @Watch('selectedIndices')
   watchSelectedIndices(newId: string | string[]) {
-    if (newId) {
+    if (!newId) {
+      this.selectValue([]);
+      return;
+    }
+
+    if (Array.isArray(newId)) {
       this.selectValue([...newId]);
+      return;
     }
+
+    this.selectValue([newId]);
   }
 
   @Listen('itemClick')

diff --git a/packages/core/src/components/select/test/cw-select.spec.tsx b/packages/core/src/components/select/test/cw-select.spec.tsx
@@ -41,6 +41,27 @@ describe('ix-select', () => {
     `);
   });
 
+  it('show add item button in list', async () => {
+    const page = await newSpecPage({
+      components: [Select, SelectItem],
+      html: `<ix-select>
+        <ix-select-item data-testid="select-1" value="11" label="Item 1"></ix-select-item>
+        <ix-select-item data-testid="select-1" value="22" label="Item 2"></ix-select-item>
+      </ix-select>`,
+    });
+
+    await page.waitForChanges();
+
+    const selectElement = page.doc.querySelector('ix-select');
+
+    selectElement.selectedIndices = '22';
+    await page.waitForChanges();
+
+    expect(
+      (screen.getByTestId('input') as HTMLInputElement).value
+    ).toStrictEqual('Item 2');
+  });
+
   it('show add item button in list', async () => {
     const page = await newSpecPage({
       components: [Select],