Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): add vue support #291

Merged
merged 24 commits into from
Mar 8, 2023
Merged

feat(vue): add vue support #291

merged 24 commits into from
Mar 8, 2023

Conversation

PhentomPT
Copy link
Contributor

@PhentomPT PhentomPT commented Jan 13, 2023

Vue3 support

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): framework support

Does this introduce a breaking change?

  • Yes
  • No

Other information

Assets

  • Vue logo

Packages

  • vue (wrapper)
  • vue-test-app
  • docs
    • vue stackblitz runtime

Docs

  • tree.md
  • validation.md
  • drawer.md
  • messagebar.md
  • tile.md
  • blind.md
  • dropdown.md
  • modal.md
  • time-picker.md
  • breadcrumb.md
  • event-list.md
  • basic-navigation.md
  • popover-news.md
  • vertical-tabs.md
  • about-and-legal.md
  • map-navigation.md
  • settings.md
  • toast.md
  • button.md
  • expanding-search.md
  • pill.md
  • toggle.md
  • category-filter.md
  • flip.md
  • adiobutton.md
  • select.md
  • upload.md
  • checkbox.md
  • group.md
  • spinner.md
  • chip.md
  • html-grid.md
  • split-button.md
  • workflow.md
  • date-picker.md
  • input.md
  • tabs.md
  • date-time-picker.md
  • kpi.md
  • textarea.md

Preview examples

  • tree.vue
  • validations.vue
  • modal.vue
  • about-and-legal.vueinput-readonly.vue
  • aggrid.vueinput-with-icon.vue
  • basic-navigation-without-header.vue
  • input.vue
  • basic-navigation.vue
  • kpi.vue
  • blind.vue
  • map-navigation-overlay.vue
  • breadcrumb-next-items.vue
  • map-navigation.vue
  • breadcrumb-truncate.vue
  • menu-with-bottom-tabs.vue
  • breadcrumb.vue
  • message-bar.vue
  • button-ghost.vue
  • button-grey-ghost.vue
  • pill.vue
  • button-grey-secondary.vue
  • popover-news.vue
  • button-grey.vue
  • radio-button.vue
  • button-group.vue
  • select-editable.vue
  • button-secondary.vue
  • select-multiple.vue
  • button-selected.vue
  • select.vue
  • button-text-icon.vue
  • settings.vue
  • button-with-icon.vue
  • spinner-large.vue
  • buttons.vue
  • spinner.vue
  • category-filter-suggestions.vue
  • split-button-icons.vue
  • category-filter.vue
  • split-button.vue
  • checkbox-indeterminate.vue
  • tabs-rounded.vue
  • checkbox.vue
  • tabs.vue
  • chip.vue
  • textarea-disabled.vue
  • datepicker-range.vue
  • textarea-readonly.vue
  • datepicker.vue
  • textarea.vue
  • datetimepicker.vue
  • tile.vue
  • drawer-full-height.vue
  • timepicker.vue
  • drawer.vue
  • toast-custom-element.vue
  • dropdown-icon.vuetoast-custom.vue
  • dropdown.vue
  • toast.vue
  • event-list-compact.vue
  • toggle-color.vue
  • event-list-custom-item-height.vue
  • toggle-custom-label.vue
  • event-list-selected.vue
  • toggle-disabled.vue
  • event-list.vue
  • toggle.vue
  • expanding-search.vue
  • flip-tile.vue
  • upload.vue
  • group-context-menu.vue
  • vertical-tabs-with-avatar.vue
  • group-custom-entry.vue
  • vertical-tabs.vue
  • group-header-suppressed.vue
  • workflow-vertical.vue
  • group.vue
  • workflow.vue
  • input-disabled.vue

@danielleroux
Copy link
Collaborator

danielleroux commented Jan 13, 2023

@PhentomPT in one of your latest JF we decided to ignore vue for now (#105 (comment)). Is there any new reason to implement the wrapper?

@PhentomPT
Copy link
Contributor Author

@PhentomPT in one of your latest JF we decided to ignore vue for now (#105 (comment)). Is there any new reason to implement the wrapper?

@danielleroux yes, here is a list on some important reasons

  • future projects in vue that want to implement the library
  • major framework with a big community
  • stencil wrapper is available, very simple & boosts integration vs pain javascript usage
  • high compatibility & low effort for documentation

@danielleroux
Copy link
Collaborator

@PhentomPT in one of your latest JF we decided to ignore vue for now (#105 (comment)). Is there any new reason to implement the wrapper?

@danielleroux yes, here is a list on some important reasons

  • future projects in vue that want to implement the library
  • major framework with a big community
  • stencil wrapper is available, very simple & boosts integration vs pain javascript usage
  • high compatibility & low effort for documentation

We have to clarify this in the next jourfix

@PhentomPT PhentomPT marked this pull request as ready for review January 23, 2023 15:07
@PhentomPT PhentomPT self-assigned this Jan 23, 2023
@danielleroux danielleroux added this to the next-release milestone Jan 26, 2023
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Jan 26, 2023
@danielleroux danielleroux changed the title feat: vue support feat(vue): add vue support Jan 31, 2023
@danielleroux danielleroux removed this from the 1.4.0 milestone Feb 16, 2023
@danielleroux danielleroux added this to the 1.5.0 milestone Feb 16, 2023
@PhentomPT
Copy link
Contributor Author

@danielleroux MR is ready

@danielleroux
Copy link
Collaborator

@danielleroux MR is ready

This is one of our main goals for 1.5.0 but as discussed in last team jf we have first to make the update to stencil v3.0.0 (#327)

@danielleroux
Copy link
Collaborator

I resolve merge conflicts after #431 is merged to main

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Maybe we have to adapt the installation disclaimer after merge.

@danielleroux danielleroux merged commit d7bb12c into main Mar 8, 2023
@danielleroux danielleroux deleted the support/vue branch March 8, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants