Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/progress-bar): add new web component 'ix-progress-bar' #1248

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

rouven-s
Copy link

@rouven-s rouven-s commented Apr 26, 2024

💡 What is the current behavior?

🆕 What is the new behavior?

Added a new core web component "ix-progress-bar".

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

  • Some linting and tests seem to be failing on other components that I have not touched.

Copy link

changeset-bot bot commented Apr 26, 2024

⚠️ No Changeset found

Latest commit: 7d50dbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@danielleroux
Copy link
Collaborator

@rouven-s Thank for your PR. We have to address some points before we can proceed here.

If this points are fulfilled we can further proceed with the code review.

pnpm-lock.yaml Outdated Show resolved Hide resolved
@danielleroux
Copy link
Collaborator

@rouven-s Lint fails on your component:
image

@danielleroux
Copy link
Collaborator

@rouven-s please read the first sentence of the linked visual regression test guide: https://github.com/siemens/ix/blob/main/CONTRIBUTING.md#visual-regression-testing. Its not allowed to add windows based snapshots these snapshots cannot be checked via github workflow.

@rouven-s
Copy link
Author

@danielleroux I added a11y and regression tests.

Following the instructions for the screenshot creation, running pnpm --filter @siemens/ix run visual-regression progress-bar -u with playwright installed locally only created win32 pngs, no linux ones.

Running docker run -p 8080:8080 -v $(cd):/work/ -w /work -it mcr.microsoft.com/playwright:v1.30.0-focal /bin/bash and then pnpm --filter @siemens/ix run visual-regression progress-bar -u with webServer.reuseExistingServer=true configuration results in this error:
Error: page.originalGoto: net::ERR_EMPTY_RESPONSE at http://127.0.0.1:8080/src/tests/progress-bar/basic?theme=theme-classic-dark

Do you have a hint on what I'm doing wrong?

@matthiashader
Copy link
Collaborator

@rouven-s I have looked a little bit more into detail and also tried setting up an docker development enviroment but it just seems that windows making strange symlinks and pnpm seems not really capable of dealing with multiple filesystems and volumes (when mounting folders). (https://pnpm.io/faq#:~:text=Does%20pnpm%20work%20across%20multiple,address%20a%20location%20in%20another.)

For further development i would suggest to you:

  1. WSL2 - Inside the WSL setup iX again, then you can connect remotely connect to the instance via your IDE
  1. Doing everything in docker (you can also remote connect and develop there)

I generally would you suggest to use the WSL2 approach, but i also wrote a small Dockerfile, so it is also possible to use:
FROM node:20 RUN corepack enable pnpm USER node:node WORKDIR /home/node RUN git clone https://github.com/siemens/ix WORKDIR /home/node/ix RUN pnpm i USER root RUN pnpm exec playwright install-deps RUN pnpm exec playwright install
Build the Dockerfile: docker build -t ix-docker-image -f .\Dockerfile .
Deploy container: docker run -p 3333:3333 -it --name ix-docker-container ix-docker-image /bin/bash

@muratayik muratayik mentioned this pull request Jun 5, 2024
2 tasks
@danielleroux
Copy link
Collaborator

@rouven-s PR review + adaptions will be part of our next sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants