Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/dropdown-item): dropdown item disabled state events & icon color #390

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #366

What is the new behavior?

  • Added pointer-events: none to the dropdown-item when disabled.
  • Corrected the icon color when dropdown-item when disabled.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard added type: bug Something isn't working component: core labels Feb 17, 2023
@goncalosard goncalosard added this to the 1.5.0 milestone Feb 17, 2023
@goncalosard goncalosard linked an issue Feb 17, 2023 that may be closed by this pull request
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux modified the milestones: 1.5.0, 1.4.0 Feb 22, 2023
@danielleroux danielleroux added pull request affects patch version The pull request affects only patch version and removed type: bug Something isn't working component: core labels Feb 22, 2023
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests regarding disabled (visual regression or unit test)
@silviowolf should the dropdown be closing automaticly if you click on a disabled item?

Dropdown should not be change visible state after clicking on an disabled item

@danielleroux danielleroux merged commit e906b50 into main Feb 23, 2023
@danielleroux danielleroux deleted the fix/dropdown-item branch February 23, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ix-dropdown-item dispatching events with property disabled
3 participants