Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/menu): menu more disabled state #527

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Disabled state not active when item is in menu more.
image

What is the new behavior?

  • Now when in menu more, disabled state activates.
    image

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard added type: bug Something isn't working component: core labels May 11, 2023
@danielleroux danielleroux added pull request affects patch version The pull request affects only patch version and removed type: bug Something isn't working component: core labels May 12, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 12, 2023
@danielleroux danielleroux merged commit 38feb8e into main May 12, 2023
@danielleroux danielleroux deleted the fix/menu-item-more branch May 12, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants