Fix RangeError on non-file drag/drop events #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConversationView responds to drag/drop events by forwarding them to its file input. The file input stops propagation and handles the event only if the data transfer is type file. This means that any other data type (text, img, etc...) causes an recursive loop of event propagation, eventually resulting in logging a "RangeError: Maximum call stack size exceeded". Fix by only forwarding files to the file input. // FREEBIE
scottnonnenberg
added a commit
that referenced
this pull request
Sep 22, 2017
Fix extended periods of not receiving messages on Linux (#1497) Fix crash on non-file drag/drop events (#1498) Dev: - yarn install now builds electron dependencies automatically (#1491) - Docs are refreshed for the new world of Electron (#1491) - Update our release scripts to match changes in electron-builder (#1484) - Additional logging when we can't decrypt a user's profile (#1483) - Remove images/emoji directory (#1485) FREEBIE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed some spurious "RangeError: Maximum call stack size exceeded" statements in the console. Investigation reveals they can be repro'd by selecting text in a message, and then dragging the text around.