Node: update dependencies #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-signal
approved these changes
Sep 20, 2021
jrose-signal
force-pushed
the
jrose/node-update-dependencies
branch
2 times, most recently
from
e41247a
to
aeb9496
Compare
|
Hmm…node-gyp 8.2.0 broke the Windows build. Commented here, though this may not be the ultimate cause: nodejs/gyp-next#121 (comment) |
On Windows, node-gyp tries to be helpful by changing forward slashes to backslashes and making paths relative to the source root rather than the build directory, and indeed we rely on that. However, it has to guess what's a path and what isn't. Previously, we worked around that by manually stripping the prepended "..\", but the node-gyp maintainers suggested a better workaround of using joined arguments instead (`--foo=bar` instead of `--foo bar`).
- Upgrade electron and typescript to match Desktop. - Manually upgrade node-gyp and electron-mocha. - Don't explicitly specify mocha; let electron-mocha choose it. - Don't explicitly specify @types/node; let electron choose it. - yarn upgrade
jrose-signal
force-pushed
the
jrose/node-update-dependencies
branch
from
aeb9496
to
b4aec0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn upgrade