Can't load libsignal_jni in windows env #484 #485
Conversation
There was a problem hiding this comment.
Thank you for picking this up! This has been broken since, uh, forever, but since libsignal_jni is primarily used for the Signal server and Android app, and none of the server and Android developers are doing their day-to-day work on Windows, we've been letting it slip by.
It's a little trickier than what you have here, because the canonical Windows library name we've been shipping is "signal_jni.dll", not "libsignal_jni.dll". But that's just making the check cover the whole filename rather than just the extension.
| String extension; | ||
| if (osName.startsWith("mac os")) { | ||
| extension = ".dylib"; | ||
| } else if(osName.contains("win")) { |
There was a problem hiding this comment.
Does startsWith not work? Seems good to keep the check narrow.
There was a problem hiding this comment.
I think the startsWIth should work indeed
|
(closed due to age and no pressing need from within Signal, anyone should feel free to pick it up and finish it off, along with testing on a Windows machine) |
#484