Change getSender method of SenderCertificate to always return the UUID #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the only user of this method is the ProtcolException constructor, when a UnidentifiedSenderMessageContent is present. All other instances of ProtocolException use the sender's UUID as sender. So it would be good to have this consistent. Also brings this in line with similar methods, like `getSourceIdentifier` on SignalServiceEnvelope.
AsamK
force-pushed
the
protocol-exception-uuid
branch
from
29be1b1
to
db43a62
Compare
jrose-signal
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
I checked with the Android team and they concur: while the current behavior made sense during the migration to UUIDs, when local recipient info was potentially in terms of just e164s (or preferring e164s), it's no longer our source of truth, and we don't need to keep this behavior from libsignal-metadata-java moving forward.
I'll cherry-pick this into our private branch and it will go out with the next release.
|
Released in v0.21.1 as ad1fabb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only user of this method is the ProtcolException constructor, when an UnidentifiedSenderMessageContent is present. All other instances of ProtocolException already use the sender's UUID as sender. So it would be good to have this consistent.
Also brings this in line with similar methods, like getSourceIdentifier on SignalServiceEnvelope in the Android app.