Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove collectd/disk monitor #3998

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Remove collectd/disk monitor #3998

merged 1 commit into from
Jan 4, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 1, 2023 •
edited

Description:

This PR removes the deprecated collectd/disk monitor in favor of the disk-io monitor. This component was deprecated 3 years 11 months.

    **This monitor has been deprecated in favor of the `disk-io` monitor.
    Please migrate to that monitor as this collectd-based monitor will be
    removed in a future release of the agent.**  Note that the `disk-io`
    monitor has a different dimension (`disk` instead of `plugin_instance`) to
    specify the disk.

@atoulme atoulme requested review from a team as code owners December 1, 2023 05:24
rmfitzpatrick
rmfitzpatrick requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@rmfitzpatrick rmfitzpatrick left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace w/ logged deprecation notice for at least a release

edit: sry, missed #4022

@atoulme
Copy link
Contributor Author

atoulme commented Jan 4, 2024

@rmfitzpatrick ok to approve at this time?

@atoulme atoulme merged commit 91dccf9 into main Jan 4, 2024
44 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove_collectd_disk branch January 4, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atoulme @rmfitzpatrick