Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation notices to deprecated plugins #4022

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Add deprecation notices to deprecated plugins #4022

merged 4 commits into from
Dec 7, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 6, 2023

No description provided.

@atoulme atoulme requested review from a team as code owners December 6, 2023 04:58
@rmfitzpatrick rmfitzpatrick mentioned this pull request Dec 6, 2023
Merged
@rmfitzpatrick
Copy link
Contributor

Mind adding collectd/elasticsearch?

@atoulme
Copy link
Contributor Author

atoulme commented Dec 7, 2023

collectd/elasticsearch uses a different method, and has a warning already:

m.Logger().Warn("The collectd/elasticsearch monitor is deprecated in favor of the elasticsearch monitor.")

splunk-otel-collector/internal/signalfx-agent/pkg/monitors/collectd/elasticsearch/elasticsearch.go

Line 77 in 0355044

m.Logger().Warn("The collectd/elasticsearch monitor is deprecated in favor of the elasticsearch monitor.")

@atoulme atoulme merged commit 8e1fd98 into main Dec 7, 2023
41 of 44 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add_deprecation_notices branch December 7, 2023 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aurbiztondo-splunk aurbiztondo-splunk aurbiztondo-splunk left review comments

@jvoravong jvoravong jvoravong approved these changes

@rmfitzpatrick rmfitzpatrick rmfitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @rmfitzpatrick @jvoravong @aurbiztondo-splunk