Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export metrics to a working endpoint when is OTEL_REALM set #2637

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

pellared
Copy link
Contributor

@pellared pellared commented Nov 14, 2023

Fixes #2582

Initially I tried reusing https://pkg.go.dev/go.opentelemetry.io/contrib/exporters/autoexport, but it resulted in too many changes that I was not comfortable with. The changes were not only related to "code", but in code that we would have to add to not break existing users (e.g. by default our distro uses insecure channel).

Testing

Here is a list manual E2E test scenarios using our example that I did to ensure that the functionality is working properly:

Via Collector

✔️

Default scenario. Setting only OTEL_SERVICE_NAME and OTEL_RESOURCE_ATTRIBUTES on the application. Use collector to send telemetry to Splunk o11y.

Direct Ingest

✔️

Additionally set SPLUNK_REALM and SPLUNK_ACCESS_TOKEN to send telemetry directly to Splunk o11y.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (28c00a5) 82.77% compared to head (5c2cff3) 82.43%.

Files Patch % Lines
distro/exporter.go 50.00% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   82.77%   82.43%   -0.34%     
==========================================
  Files          83       83              
  Lines        3228     3246      +18     
==========================================
+ Hits         2672     2676       +4     
- Misses        483      497      +14     
  Partials       73       73              
Flag Coverage Δ
Linux 82.13% <50.00%> (-0.34%) ⬇️
Windows 78.36% <50.00%> (-0.38%) ⬇️
macOS 77.84% <50.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared pellared marked this pull request as ready for review November 16, 2023 21:50
@pellared pellared requested review from a team as code owners November 16, 2023 21:50
@pellared pellared merged commit 16e08c4 into signalfx:main Nov 16, 2023
15 checks passed
@pellared pellared deleted the fix-2582 branch November 16, 2023 22:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to export metrics directly to o11y
3 participants